Skip to content

Update adapter.js#196

Closed
Ozhvankov wants to merge 2 commits into
balderdashy:masterfrom
Ozhvankov:patch-1
Closed

Update adapter.js#196
Ozhvankov wants to merge 2 commits into
balderdashy:masterfrom
Ozhvankov:patch-1

Conversation

@Ozhvankov

@Ozhvankov Ozhvankov commented Sep 24, 2015

Copy link
Copy Markdown

fix stream function:
change to new query builder
line 930-939
new Query --> new Sequel

@Ozhvankov
Update adapter.js
1cb029f 
fix stream function:
change to new query builder
line 930-939 
new Query --> new Sequel
@devinivy

devinivy commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

Hey @Ozhvankov, thanks for your contribution! A couple questions,

  • The build doesn't pass because ./query as required doesn't exist inside the repo.
  • Can you explain the change around removing formattedErr.originalError = err;?
  • Can you remove unused commented code and console.logs?
  • Does this resolve a particular github issue?

@Ozhvankov
Update adapter.js
564d69f 
bug fix of path-1
thanx for U "focus" on removing formattedErr.originalError = err;
its our mistake
@Ozhvankov

Ozhvankov commented Sep 24, 2015

Copy link
Copy Markdown
Author

bug fix of patch-1
thanx for U "focus" on removing formattedErr.originalError = err;
its our mistake

@devinivy

devinivy commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

Just leaving this build failure here, but I think it's a timing issue that needs to be fixed in the adapter tests. I'm going to re-run the build, and hopefully it will pass.

  autoIncrement attribute feature
  ✓ should auto generate unique values
  1) should auto generate unique values even when values have been set
Error (E_VALIDATION) :: 1 attribute is invalid
Error (E_VALIDATION) :: 1 attribute is invalid
error: duplicate key value violates unique constraint "autoIncTable_pkey"
    at Socket.<anonymous> (_stream_readable.js:765:14)
    at emitReadable_ (_stream_readable.js:427:10)
    at emitReadable (_stream_readable.js:423:5)
    at readableAddChunk (_stream_readable.js:166:9)
    at Socket.Readable.push (_stream_readable.js:128:10)
    at TCP.onread (net.js:529:21)
Invalid attributes sent to undefined:
 • id
   • A record with that `id` already exists (`5`).
  262 passing (4s)
  2 pending
  1 failing
  1) autoIncrement attribute feature should auto generate unique values even when values have been set:
     [Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to undefined:
 • id
   • A record with that `id` already exists (`5`).
  Error (E_VALIDATION) :: 1 attribute is invalid
  Error (E_VALIDATION) :: 1 attribute is invalid
  error: duplicate key value violates unique constraint "autoIncTable_pkey"
      at Socket.<anonymous> (_stream_readable.js:765:14)
      at emitReadable_ (_stream_readable.js:427:10)
      at emitReadable (_stream_readable.js:423:5)
      at readableAddChunk (_stream_readable.js:166:9)
      at Socket.Readable.push (_stream_readable.js:128:10)
      at TCP.onread (net.js:529:21)

@particlebanana

particlebanana commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

Whoops sorry @Ozhvankov didn't see this. I added #221 which adds the pg-query-stream dependency along with these patches. We need to add some tests and get it documented before it can be merged though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ozhvankov @devinivy @particlebanana